Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code syntax highlighting colors #22

Open
alex-dixon opened this issue Sep 10, 2019 · 5 comments
Open

Code syntax highlighting colors #22

alex-dixon opened this issue Sep 10, 2019 · 5 comments
Assignees
@austinlxx
Labels
site

Comments

@alex-dixon
Copy link
Contributor

@austinlxx Per our discussion we want readability first, style points second. Preferably we will have both, but if we have to choose one users should be able to read the code from space
@austinlxx
Copy link
Contributor

@alex-dixon any preferences from these?
I can also look into dark themes, but will have to experiment on how it looks overall in the Documentation.
image
image
image

@alex-dixon
Copy link
Contributor Author

How much control do we have over the colors? In general I like base16. Saw a GitHub light variant for va code that seemed cool

@austinlxx
Copy link
Contributor

We have control over all the colors, through PrismJS 😉

@alex-dixon
Copy link
Contributor Author

@austinlxx I think we need to make the bracket color a lot darker or more contrast-y with the white background

@alex-dixon
Copy link
Contributor Author

Would still prefer more contrast but removing as a release blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinlxx austinlxx

Labels
site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-dixon @austinlxx