Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.3.0-beta.8] When configured tap_action: {} it doesn't do anything, but the UI shows it does a Toggle #953

Open
michaelarnauts opened this issue Nov 22, 2024 · 2 comments · May be fixed by #1076
Assignees
Labels
bug Something isn't working Confirmed One of the collaberators confirmed this bug.

Comments

@michaelarnauts
Copy link

Describe the bug

When clicking on the X button in the Tap action selection, the selection stays "Toggle", but the YAML will be filled in as tap_action: {}.

image

Then, when clicking the card in the dashboard, it doesn't trigger a toggle but does nothing. However the UI shows it should Toggle, this is confusing and kept me searching for a while why my switch didn't toggle.

type: custom:bubble-card
card_type: button
entity: switch.woonkamer_fireplace_mode
button_action:
  tap_action: {}

Informations (please complete the following information):

  • OS: All
  • Browser/App: All
  • Bubble Card version: v2.3.0-beta.8
  • Home Assistant version: 2024.11.1

Additional context
Add any other context about the problem here.

Thank you! 🍻

@michaelarnauts michaelarnauts added the bug Something isn't working label Nov 22, 2024
@michaelarnauts michaelarnauts changed the title When configured tap_action: {} it doesn't do anything, but the UI shows it does a Toggle [v2.3.0-beta.8] When configured tap_action: {} it doesn't do anything, but the UI shows it does a Toggle Nov 22, 2024
@Clooos
Copy link
Owner

Clooos commented Nov 22, 2024

Hi! You need to set it to No action in that case, this cross shouldn't be there and I forgot to remove it.

@Clooos
Copy link
Owner

Clooos commented Nov 24, 2024

I tried this a bit more and indeed the editor is not always writing the YAML config correctly in these cases, I really need to do full refactoring of the editor code, I'm aware of that 😅

This code is almost the same since the first Bubble Card beta, I was just starting my first JS project and I rushed it in a very nasty way, I'm not proud of that code (at all).

This is not my priority right now because it mostly works as it should, but it will come!

@MrBearPresident MrBearPresident added the Confirmed One of the collaberators confirmed this bug. label Dec 10, 2024
@MrBearPresident MrBearPresident linked a pull request Dec 22, 2024 that will close this issue
10 tasks
@MrBearPresident MrBearPresident self-assigned this Dec 22, 2024
@MrBearPresident MrBearPresident linked a pull request Dec 22, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Confirmed One of the collaberators confirmed this bug.
Projects
None yet
3 participants