Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-View Back button bug #590

Open
kanichrnd opened this issue Jun 17, 2024 · 11 comments
Open

Sub-View Back button bug #590

kanichrnd opened this issue Jun 17, 2024 · 11 comments
Labels
documentation Improvements or additions to documentation no-stale wontfix This will not be worked on

Comments

@kanichrnd
Copy link

Describe the bug
If you use bubble card in Sub-View page, and then want to go back to main view page, you have to press back button as many times as you opened the bubble card.

To Reproduce
Steps to reproduce the behavior:

  1. Create Sub-View page
  2. Create bubble card inside it
  3. Open and close bubble card 3-5 times
  4. Try to go back from Sub-View by pressing Back button

Expected behavior
Back button should work from the 1st click

Informations (please complete the following information):

  • OS: Windows and iOS
  • Edge, Firefox
  • 2.0.4
  • 2024.6.3

Thank you! 🍻

@kanichrnd kanichrnd added the bug Something isn't working label Jun 17, 2024
@Mofeywalker
Copy link

I have the same problem, but more specific. It's only when a popup is used un a sub view.

@Clooos
Copy link
Owner

Clooos commented Aug 23, 2024

Hi, I've changed something in the latest release that might have fixed that, can I have some feedback? 🤞

https://github.com/Clooos/Bubble-Card/releases/tag/v2.2.4

@Mofeywalker
Copy link

Hi @Clooos unfortunately, the popup is now opened again when I hit the back button in the sub view. Now it is not possible to go back to the main view.

I attached a little screen recording which shows the behaviour.

Screen_Recording_20240824_090034_Home.Assistant.mp4

Thank you again for your time and effort!

@Clooos
Copy link
Owner

Clooos commented Aug 24, 2024

Thank you for the details! I have misunderstood this issue and this shouldn't be too difficult to fix.

@Mofeywalker
Copy link

Hi, I found a way to fix this behaviour. There is an option back_path: /lovelace/home which can be applied on the subviews. I found the solution in this issue. This allows to always return back to the home view instead of "back button" press. :)

@himisk2022
Copy link

That us a good solution! unfortunately not if you open popups on the main page and want to close the app with the back button or want to return to the normal history in the browser.

@lennon101
Copy link

+1 on this issue. If I use a bubble pop up card in a sub view, I now can't navigate back to the main view because the back button of the sub view returns me to the bubble pop up card instead (as shown in the screen recording)

trim.E1455900-57DF-4675-83E3-522C4A01511B.MOV

@Clooos
Copy link
Owner

Clooos commented Sep 27, 2024

There is sadly nothing that I can do directly in Bubble Card for this, that button acts as a back button and when you open a pop-up the URL is modified, so pressing that button will automatically re-open that pop-up.

But have you checked this comment? This should fix your issue in that specific use case.

#590 (comment)

@lennon101
Copy link

Yeah leagend! I did indeed see that comment but I didn't read it in it's completeness and thought the fix wasn't going to apply in my case. But I just applied it and it does indeed resolve my issue. I appreciate that (due to the nature of how the bubble card works regarding modifying the url and therefore the history of the urls) there isn't much that can be done from here. I recommend this issue be closed for now with a comment pinned regarding the fix (for those where the fix applies 😄)

Or perhaps the fix could be documented in a FAQ or a note in the ReadMe regarding sub-views and the back button?

Cheers, and again: amazing work! 🎉

@Clooos
Copy link
Owner

Clooos commented Sep 27, 2024

Good idea indeed! I will let this issue open until I've documented this fix 👌

@Clooos Clooos pinned this issue Oct 4, 2024
@MrBearPresident MrBearPresident added documentation Improvements or additions to documentation wontfix This will not be worked on no-stale and removed bug Something isn't working labels Dec 16, 2024
@MrBearPresident
Copy link
Collaborator

@Knight1981 Merging from #1069.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-stale wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants