Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.3.2] Media Card Type not hiding buttons #1033

Open
Grahamvs opened this issue Dec 12, 2024 · 12 comments
Open

[v2.3.2] Media Card Type not hiding buttons #1033

Grahamvs opened this issue Dec 12, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@Grahamvs
Copy link

Describe the bug
When editing the Media card, if you try setting a button to "hidden", it doesn't change visibility. Returning to edit the card shows all media buttons are set to "show".

To Reproduce

  1. Edit media card
  2. Go to "Display/Hide Buttons"
  3. Set a button (like Power) to be hidden.
  4. Click Save
  5. Take note that the button is not hidden.
  6. Edit the media card again.
  7. Go to "Display/Hide Buttons"
  8. See all buttons are set to "Show"

Expected behaviour
The button should be hidden.

Screenshots

image

Information (please complete the following information):

  • OS: Windows/Android
  • Browser/App: Firefox/Android app
  • Bubble Card version: 2.3.2
  • Home Assistant version: 2024.12.2

Thank you! 🍻

@Grahamvs Grahamvs added the bug Something isn't working label Dec 12, 2024
@Clooos
Copy link
Owner

Clooos commented Dec 12, 2024

Hi! This is weird because I can't reproduce this issue 🤔 Hiding buttons is working for me, just to be sure, check that you see v2.3.2 at the bottom of the Bubble Card editor.

@CykloneFij
Copy link

Not experiencing this either, however, I have another issue with the new visibility option.
But I am responding here because the button editor shows 2.3.0 even though I updated to 2.3.2. In HACS it shows as 2.3.2.

Screenshot 2024-12-12 142221

@Clooos
Copy link
Owner

Clooos commented Dec 12, 2024

Hi, just clear your cache, then refresh, this happen after almost every updates 🙂

@Grahamvs
Copy link
Author

Grahamvs commented Dec 12, 2024

Not sure if your last comment was for me or the other guy, but I'm definitely running v2.3.2 and this didn't work with the previous versions (v2.2) either. I've deleted the cache from both Firefox on Windows, as well as the app cache on Android.

The main reason I'm trying to hide the power button is that it doesn't work when the TV is off, so I want to implement my own button that uses the WoL feature when it's off.

@Clooos
Copy link
Owner

Clooos commented Dec 12, 2024

Can you check your browser console? You might have some errors, even if I really don't understand this. Can you also try by creating a new media player card?

@Grahamvs
Copy link
Author

I added a new media card and immediately set the power button to hidden. This worked, but now I can't make the power button visible, lol.

I'm also getting the following error in the web console:

Uncaught TypeError: "power_button" is read-only _valueChanged bubble-card.js:1325 handleEvent lit-html.ts:2018 firstUpdated mwc-switch-base.ts:121 firstUpdated mwc-switch-base.ts:120 o Babel value ha-switch.ts:8 _$AE reactive-element.ts:1376 performUpdate reactive-element.ts:1343 scheduleUpdate reactive-element.ts:1261 _$Ej reactive-element.ts:1233 requestUpdate reactive-element.ts:1208 _$Eu reactive-element.ts:946 w reactive-element.ts:931 A lit-element.ts:115 o base-element.ts:20 f mwc-switch-base.ts:23 e ha-switch.ts:8 k scoped-custom-element-registry.js:385 t scoped-custom-element-registry.js:236 u lit-html.ts:1129 g lit-html.ts:1543 _$AI lit-html.ts:1384 Z lit-html.ts:2183 update lit-element.ts:165 performUpdate reactive-element.ts:1329 scheduleUpdate reactive-element.ts:1261 _$Ej reactive-element.ts:1233 requestUpdate reactive-element.ts:1208 set reactive-element.ts:726 setConfig bubble-card.js:1 value hui-element-editor.ts:394 value hui-element-editor.ts:95 value hui-element-editor.ts:89 j lit-html.ts:1883 _$AI lit-html.ts:1825 v lit-html.ts:1192 g lit-html.ts:1553 _$AI lit-html.ts:1384 Z lit-html.ts:2183 update lit-element.ts:165 performUpdate reactive-element.ts:1329 scheduleUpdate reactive-element.ts:1261 _$Ej reactive-element.ts:1233 requestUpdate reactive-element.ts:1208 _$Eu reactive-element.ts:946 w reactive-element.ts:931 A lit-element.ts:115 F hui-dialog-edit-card.ts:53 k scoped-custom-element-registry.js:385 t scoped-custom-element-registry.js:236 element make-dialog-manager.ts:78 promise callback*d make-dialog-manager.ts:77 u make-dialog-manager.ts:163 r fire_event.ts:76 o show-edit-card-dialog.ts:25 value hui-section.ts:256 r fire_event.ts:76 value hui-card-edit-mode.ts:268 value hui-card-edit-mode.ts:232 handleEvent lit-html.ts:2018

@MrBearPresident
Copy link
Collaborator

Hi

Due to some issues identified in the latest releases (v2.3.1, v2.3.2, v2.3.3), I have decided to mark them as pre-release versions. These updates may not be fully stable and could cause unexpected behavior. I strongly recommend rolling back to the latest stable release, v2.3.0, until further notice. This version has been thoroughly tested and provides a reliable experience. Thank you for your understanding and patience as we work to ensure a future updates that meets the highest standards of quality.


[u]How to rollback[/u]

  1. Click on the integration in HACS.
  2. Click on the three dots icon top right of the page.
  3. Select Redownload.
  4. Choose the version you want from the dropdown list.
  5. Click Download.

@MrBearPresident MrBearPresident changed the title Media Card Type not hiding buttons [v2.3.2] Media Card Type not hiding buttons Dec 13, 2024
@Grahamvs
Copy link
Author

I'll have to stick with v2.3.3 (upgraded about 30 minutes ago) as I'm using the climate control bubble card for my TRVs. I can work around this issue for now.

@Grahamvs
Copy link
Author

As a side note, when adding a new media card, it only allows me to set 1 button as hidden.

@MrBearPresident
Copy link
Collaborator

Can you try the newest bèta to see of this solves your issue.
Please report back if it does.

@Grahamvs
Copy link
Author

@MrBearPresident, no change. Tried with a new media card after clearing all cache, and it still gets stuck on the first button you hide.

1 similar comment
@Grahamvs
Copy link
Author

@MrBearPresident, no change. Tried with a new media card after clearing all cache, and it still gets stuck on the first button you hide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants