[client-v2] Testing the JDBC driver

[Paultagoras]

Phase 1 - Automated Connector Tests (ETA: 11/22)

Preview Give feedback

1. [jdbc-v2] Metabase testing issues #2021 (Serge, Mark)
2. DBeaver Sanity Tests (Sergey)
3. clickhouse-r2dbc (Mark)
4. [client-v2] JDBC Data Types Test Coverage #1957
   +0
   
5. Advanced example (Paul)
6. Adapt Clickbench queries (Paul)

Phase 2 - Manual Connector Testing (ETA: 11/22)

Preview Give feedback

1. Tableau (Manual - Mark)
2. TestContainers (Mark)
3. DataGrip (Paul)
4. Apache Spark (Simple example from docs - Mark)
5. Tableau TDVT Automated - @mzitnik @BentsiLeviav

Phase 3 - Nice to have testing (ETA: 11/27)

Preview Give feedback

1. Flink Connector (Sergey)
2. JOOQ (Sergey)

[PeaStew]

missing the database parameter as per https://clickhouse.com/docs/en/integrations/tableau which means no default database is available for selection

[slvrtrn]

Metabase tests fail on the latest snapshot.
Somewhere in the Metabase internals there is autoCommit = false setting

clojure.lang.ExceptionInfo: Error loading data: INSERT FAILED: setAutoCommit = false not supported

this throws in v2:

clickhouse-java/jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java

Lines 130 to 136 in 5e304cb

	@Override
	public void setAutoCommit(boolean autoCommit) throws SQLException {
	checkOpen();
	if (!autoCommit) {
	throw new SQLFeatureNotSupportedException("setAutoCommit = false not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED);
	}
	}

IMO should be just ignored with no-op, cause many standard implementations will try to set these

[chernser]

@slvrtrn
In the new version we are trying to follow JDBC javadoc - if something is not implemented we are throwing exception.
So we have two options:

• create a option flag to ignore unimplemented values - the fastest solution
• implement simple "transaction" - however it will work only when we build SQL as string. In the future it will not work when we stream data to server (we are not going to support transactions very soon or emulate them on client side)

[GEORGE-BOAST]

missing the database parameter as per https://clickhouse.com/docs/en/integrations/tableau which means no default database is available for selection

What is the solution here? I am trying to setup tableau cloud (on desktop) to connect to my xxx database on clickhouse and no tables appear.

[mshustov]

@GEORGE-BOAST what driver version do you use? Could you fill in a new bug report?

[GEORGE-BOAST]

do

I am using the latest JDBC driver with the latest version of tableau desktop.

I cannot connect using SSL, when not having said box checked, I can connect, however no tables show.

Example;

Code: 62. DB::Exception: Syntax error: failed at position 11 ('.'): .tree_lst;. Expected end of query. (SYNTAX_ERROR) (version 24.11.1.2557 (official build))
Unable to connect to the ClickHouse JDBC by ClickHouse, Inc. server “172.X.X.X”. Check that the server is running and that you have access privileges to the requested database.
Connector Class: clickhouse_jdbc, Version: 0.3.1
For support, contact ClickHouse, Inc..

[slvrtrn]

In the new version we are trying to follow JDBC javadoc - if something is not implemented we are throwing exception.
So we have two options:

So we have two options:

• create a option flag to ignore unimplemented values - the fastest solution
• implement simple "transaction" - however it will work only when we build SQL as string. In the future it will not work when we stream data to server (we are not going to support transactions very soon or emulate them on client side)

As a user, I think my preferred solution is no-op in case of unsupported standard things. So I guess option one is good.

[mshustov]

Code: 62. DB::Exception: Syntax error: failed at position 11 ('.'): .tree_lst;. Expected end of query. (SYNTAX_ERROR) (version 24.11.1.2557 (official build))

AFAIK neither version of the driver modifies the query. please fill a bug report and include the failing query, which you can find in clickhouse system.query_log