Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Added implementation for Bearer token auth #1904

Merged
merged 7 commits into from
Dec 18, 2024
Merged

[client-v2] Added implementation for Bearer token auth #1904

merged 7 commits into from
Dec 18, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 4, 2024 •
edited
Loading

Summary

Implements Bearer authentication for client v2 only.

Closes: #1834

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from mzitnik November 4, 2024 22:07
@chernser chernser marked this pull request as draft November 5, 2024 18:09
@chernser chernser marked this pull request as ready for review December 12, 2024 20:41
mzitnik
mzitnik reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add cloud tests?

@Paultagoras
Copy link
Contributor

Needs a fix for Build it seems?

@chernser
Copy link
Contributor Author

@mzitnik I think yes, we can implement cloud tests. I will do it may be in the next PR.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.3% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@chernser chernser merged commit d458d60 into main Dec 18, 2024
61 of 62 checks passed
@chernser chernser deleted the v2_jwt_auth branch December 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik mzitnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Bearer token authorization
3 participants
@chernser @Paultagoras @mzitnik