Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Pinot benchmark does not have indices. #37

Open
didip opened this issue Oct 6, 2022 · 9 comments
Open

The Pinot benchmark does not have indices. #37

didip opened this issue Oct 6, 2022 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@didip
Copy link

didip commented Oct 6, 2022

I am not a user of Pinot so unfortunately I cannot help in this case.

But it seems like it should have indices.

@alexey-milovidov
Copy link
Member

What indices to add?

@alexey-milovidov alexey-milovidov added the help wanted Extra attention is needed label Oct 7, 2022
@alexey-milovidov
Copy link
Member

I have found that people from Pinot tried to add a benchmark version with indices but did not submit it:
main...gortiz:ClickBench:main

@alexey-milovidov
Copy link
Member

If you can take these changes and make them ready for a pull request, it will be helpful.

@MacNale
Copy link

MacNale commented Aug 4, 2023

@alexey-milovidov https://docs.pinot.apache.org/basics/indexing

Can you please bump up the pinot version to 0.12.1?

@alexey-milovidov
Copy link
Member

Yes, ClickBench can install any version; please edit this file: https://github.com/ClickHouse/ClickBench/blob/main/pinot/benchmark.sh

Then you can send the results, or we can run it.

@MacNale
Copy link

MacNale commented Aug 9, 2023

okay.. Let me take a stab it. I am not a pinot expert. I am trying to evaluate Pinot vs clickhouse for my use case with my own data. This benchmark is a good start.

As per this blog 'https://startree.ai/blog/a-tale-of-three-real-time-olap-databases', pinot performs better than clickhouse. Nevertheless, let me read about pinot indexes before I come up with suggestions.

@alexey-milovidov
Copy link
Member

We stumbled upon this article and found many factual errors and misrepresentations.

We did not find any reproducible scenario where Pinot can be faster than ClickHouse.
Moreover, Pinot is much inferior in usability - you will find obstacles starting with installation and data loading.

@wisercoder
Copy link

The major selling point of Pinot is star tree index. Any comparison that doesn't leverage star tree index is invalid.

@rschu1ze
Copy link
Member

rschu1ze commented Dec 6, 2024

@wisercoder Fair enough. Unfortunately, none of the guys at ClickHouse is an expert in Pinot tuning. Feel free to send a PR that adds indices to Pinot's ClickBench DDL. I am happy to try it out and update benchmark results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants