-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Metabolic Hyperefficiency causes major lag spikes with higher intelligence #72781
Comments
(First set of ingame hours: Your save, 2 intelligence. Second set: Your save, 25 intelligence.) Unable to reproduce with in-repo mods
|
#72773 should at least cause high levels of weariness to turn off your powers. |
Well, I loaded up the save using in-repo mods and activated Metabolic Hyperefficiency. One step immediately dropped me to Extremely Weary, and: Also, the character was freezing to death for some reason.
|
I updated to 4aef748 which includes your new PR mentioned above and I'm still not able to reproduce on MSVC (have not tried other versions). 2024-04-01.22-40-47.mp4 |
Probable reason: same as #72255; while the zero metabolism do not hang the game anymore, values close to zero still can cause a lot of slowdown due the loop Ren posted before. |
Bumping this issue. I experienced this bug and being an 18 Int Snail Mutant with a Recycler CBM was enough to completely break my game/save file. That makes it a base game save-breaking bug that would tend to kick in on files that had time to establish Light Eater+Recycler. I had to edit out the Recycler CBM to continue playing. It's bad. (Thanks to the discord server for helping me troubleshoot and esp @GuardianDll ) |
index 2796a2039f..70a9341a4c 100644
--- a/src/consumption.cpp
+++ b/src/consumption.cpp
@@ -715,7 +715,9 @@ float Character::metabolic_rate_base() const
{
static const std::string hunger_rate_string( "PLAYER_HUNGER_RATE" );
float hunger_rate = get_option< float >( hunger_rate_string );
- return enchantment_cache->modify_value( enchant_vals::mod::METABOLISM, hunger_rate );
+ const float final_hunger_rate = enchantment_cache->modify_value( enchant_vals::mod::METABOLISM,
+ hunger_rate );
+ return std::clamp( final_hunger_rate, 0.0f, float_max );
}
// TODO: Make this less chaotic to let NPC retroactive catch up work here The basic issue is that Character::metabolic_rate_base() comes back negative so Character::weariness_level() gets stuck in the while loop constantly incrementing the |
Describe the bug
At about 20 intelligence, actions like moving/eating/waiting start to lag noticeably, and the higher intelligence you have the nastier the lagging becomes. Because using the power also makes you too weary for 'stop concentration' and toggling the power off, the only way to turn it off is to fall asleep, which depending on how tired you are, can take forever due to the lagging.
Attach save file
Everest-trimmed.tar.gz
Steps to reproduce
Expected behavior
I expected the lagging to not exist.
Screenshots
No response
Versions and configuration
Dark Days Ahead [dda],
Bionic Professions [package_bionic_professions],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth],
Mythical Martial Arts [MMA],
<color_yellow>Mythical Martial Arts - Mods Extension [MMA_Mods_Extension],
Bombastic Perks [bombastic_perks],
Magiclysm [magiclysm],
Magiclysm Revamp and Additions [magicrevamp],
Miscellaneous Magiclysm Expansions [demon_spider_a],
Magiclysm No Class Limit [magiclysm_no_class_limit],
Aftershock [aftershock],
Xedra Evolved [xedra_evolved],
No Bionic Slots [no_cbm_slots],
Mind Over Matter [mindovermatter],
Mind Over Matter: <color_magenta>Remove Random Delay Before Learning New Powers [mom_no_power_learn_delay],
Mind Over Matter: <color_magenta>Remove Concentration Limit [mom_infinite_concentration],
Mind Over Matter: <color_magenta>Awakenings Are Always Successful [mom_always_awaken],
Mind Over Matter: <color_magenta>No Negative Nether Attunement Effects [mom_no_negative_nether_attunement],
Mind Over Matter: <color_magenta>Feral Psions Always Drop Crystals [mom_feral_psions_always_crystals],
SpeedyDex [speedydex],
Stats Through Kills [stats_through_kills],
Stats Through Skills [StatsThroughSkills],
Extended Freeform [Extended_freeform],
Japanese Folklore [Jap_folklore]
]
Additional context
No response
The text was updated successfully, but these errors were encountered: