Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make highlighter production-ready #3

Open
3 tasks
DivineDominion opened this issue Jul 14, 2017 · 0 comments
Open
3 tasks

Make highlighter production-ready #3

DivineDominion opened this issue Jul 14, 2017 · 0 comments
Labels
enhancement

Comments

@DivineDominion
Copy link
Collaborator

DivineDominion commented Jul 14, 2017 •
edited
Loading

As of now, the yellow highlighter doesn't work in some cases.

  • Resizing the window vertically changes textContainerInsets, and the highlighter needs to be moved by the delta of textContainerInset.height - overscrollTopOffset from before and after the update
  • Resizing the window horizontally causes a reflow of text and thus moves the insertion point around on screen. The highlighter does not follow
  • Make highlighter color configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DivineDominion