Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Tools Button Visibility Code Error #36

Open
metaton8086 opened this issue Oct 4, 2022 · 1 comment
Open

Zoom Tools Button Visibility Code Error #36

metaton8086 opened this issue Oct 4, 2022 · 1 comment

Comments

@metaton8086
Copy link

On line 151 on the JoinZoom_Main_4-1-1.js, it shows the following:

Visibility: visibility

I believe this should be:

Visibility: 'Auto'

@bomcgoni
Copy link
Contributor

bomcgoni commented Oct 4, 2022

Hello Metaton,

Line 151 is apart of a function between lines 147 through 160 called zoomToolsVisibility (see below). This function is used to hide and show the Zoom Tools UI as needed. visibility on line 151 is referencing the function parameter on line 147 and can change depending on when this function is called when the script is live.

For example, if the UI needs to be show, the function will be executed as zoomToolsVisibility('Auto') or as function zoomToolsVisibility('Hidden').

But you'll see additional logic in the function that references the config config.ui.settings.dtmfTools which if this is true, it will allow this UI to show and hide with the call, else it will always remain hidden.

With that said, are you facing any issues with the Zoom Tools UI?

function zoomToolsVisibility(visibility) {
    if (config.ui.settings.dtmfTools) {
        xapi.command('UserInterface Extensions Panel Update', {
            PanelId: `jzoomTools~${config.version}~Tools~Visible`,
            Visibility: visibility
        })
    }
    else {
        xapi.command('UserInterface Extensions Panel Update', {
            PanelId: `jzoomTools~${config.version}~Tools~Visible`,
            Visibility: 'Hidden'
        })
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants