Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent nvm from falling back to building from source #183

Open
JamesHallowell opened this issue Mar 20, 2023 · 2 comments · May be fixed by #185
Open

Prevent nvm from falling back to building from source #183

JamesHallowell opened this issue Mar 20, 2023 · 2 comments · May be fixed by #185
Assignees
@KyleTryon
Labels
feature_request

Comments

@JamesHallowell
Copy link

We've hit an issue that if the binary download fails, then nvm will fall back to building Node from source. This takes a long time and burns through credits, when it'd be quicker to just fail and try the job again.

nvm does support the -b option for installs so that it will only install from binary, and skip installing from source. It would be nice if this orb either set this option all the time, or provided some way to opt in to setting it.

Thanks!
@KyleTryon
Copy link
Contributor

KyleTryon commented Apr 5, 2023 •
edited

I'm tempted to set it all the time. I doubt anyone really wants to wait that long, if they did they would be far better off building their own image once.

Does anyone have any concerns? we'd probably have to make it a major change, unfortunately.

@KyleTryon KyleTryon self-assigned this Apr 5, 2023
@olleolleolle
Copy link
Contributor

olleolleolle commented Apr 18, 2023 •
edited

👋 Hi! We are in the same situation, and would like not to fall back either! Registering "no concerns"!

@dsanders11 dsanders11 linked a pull request Jul 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KyleTryon KyleTryon

Labels
feature_request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: do not fall back to source builds of Node.js dsanders11/circleci-node-orb
3 participants
@olleolleolle @JamesHallowell @KyleTryon