Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MSI Packager To a More Maintainable Way #342

Open
hollowaykeanho opened this issue Jun 17, 2024 · 6 comments
Open

Refactor MSI Packager To a More Maintainable Way #342

hollowaykeanho opened this issue Jun 17, 2024 · 6 comments
Assignees
@hollowaykeanho
Labels
Done and Pending Release Completed and staging for next release. Enhancement Case is about improving an existing feature/aspect. NON-Backward Compatible Solution is NOT backward compatible.

Comments

@hollowaykeanho
Copy link
Member

hollowaykeanho commented Jun 17, 2024 •
edited
Loading

Description

This includes:

  1. Closing this issue: {iso639-1}[-{iso15954}][-iso31661 alpha2] for Locale Identification wixtoolset/issues#7896
  2. detect both binary and library built artifact instead of relying on placeholder files.
  3. Ensures the new enhancement are applied.

Expected Behavior

MSI packager works as usual, the github issue is closed so that the upstream folks can have peace in mind and move on.

Current Behavior

MSI packager is wey too complicated and the upstream github issue is holding things up. Upstream team is annoyed with the slow timeline already.

Associated Data Files

No response
@hollowaykeanho hollowaykeanho added Enhancement Case is about improving an existing feature/aspect. Discussion Matter is still in discussion. No commitment yet. labels Jun 17, 2024
@hollowaykeanho hollowaykeanho self-assigned this Jun 17, 2024
@hollowaykeanho hollowaykeanho removed the Discussion Matter is still in discussion. No commitment yet. label Jun 17, 2024
@hollowaykeanho hollowaykeanho moved this from Buckets to v3.0.0 in AutomataCI Jun 17, 2024
@github-project-automation github-project-automation bot moved this to Buckets in AutomataCI Jun 17, 2024
@hollowaykeanho hollowaykeanho added the In Progress Someone is working on the case. label Jun 17, 2024
@hollowaykeanho
Copy link
Member Author

Begin upgrades.

@hollowaykeanho hollowaykeanho changed the title Refactor MSI Packager To a More Maintainer Way Refactor MSI Packager To a More Maintainable Way Jun 18, 2024
@hollowaykeanho
Copy link
Member Author

Issue has already been updated with the LCID findings and -culture argument test results. Once the CI is passing from the hestiaERROR project, upstream to this repository is then possible.

@hollowaykeanho hollowaykeanho added the NON-Backward Compatible Solution is NOT backward compatible. label Jun 20, 2024
@hollowaykeanho
Copy link
Member Author

Will not be backward compatible since the refactoring efforts are way cleaner and disruptive + using a single install pack per language rather than assembling things manually.

@corygalyna
Copy link
Contributor

I would suggest you drop the upstream tracking as a criteria. The 2 issues are isolated now and you can close this issue upon upstream.

@hollowaykeanho
Copy link
Member Author

noted.

@hollowaykeanho
Copy link
Member Author

implemented in ef00944

@hollowaykeanho hollowaykeanho added Done and Pending Release Completed and staging for next release. and removed In Progress Someone is working on the case. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollowaykeanho hollowaykeanho

Labels
Done and Pending Release Completed and staging for next release. Enhancement Case is about improving an existing feature/aspect. NON-Backward Compatible Solution is NOT backward compatible.
Projects
AutomataCI
Status: v3.0.0
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hollowaykeanho @corygalyna