Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update): update maroto from v1.0.0 to v2.0.0 #6782

Open
johnfercher opened this issue Oct 28, 2023 · 1 comment
Open

feat(update): update maroto from v1.0.0 to v2.0.0 #6782

johnfercher opened this issue Oct 28, 2023 · 1 comment
Labels
community Community contribution feature request Community: new feature request

Comments

@johnfercher
Copy link

Is your feature request related to a problem? Please describe. (this is not an actually new feature)

Hello, I'm the creator of johnfercher/maroto and I see that you use the old version of maroto to generate a report in your project. I would like to purpose to use kics as a pilot to maroto v2. The project just reached the first beta version (after 42 alpha versions). The v2 is easier than v1, runs twice as fast as v1, allows unit tests and have a bunch of new features.

Describe the solution you'd like
I would refactor the current code to use the v2, keeping the exactly same PDF structure that is generated today. I will create unit tests to warrant that the PDF is correct and I will provide benchmarks of the time execution of the report.

Additional context
I will also provide support to your project, helping with any issues and even adding features to maroto v2 to meet kicks need.

@johnfercher johnfercher added community Community contribution feature request Community: new feature request labels Oct 28, 2023
@kaplanlior
Copy link
Member

Hi @johnfercher

Thanks for reaching out. I first want to make sure we use the latest v1 version before checking v2.

If you want to create the PR for v2, we could test in during the nightly builds to see if it's ready to be part of a release.
We won't be able to do many "ping pongs" with this, but let's try at least once to help you gather the feedback.

It would also be a good opportunity to polish our tests in this area. In contribution would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request
Projects
None yet
Development

No branches or pull requests

2 participants