Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple managers from platform's Chameleon #215

Open
1 task done
LooFifteen opened this issue Mar 30, 2023 · 2 comments
Open
1 task done

Decouple managers from platform's Chameleon #215

LooFifteen opened this issue Mar 30, 2023 · 2 comments
Labels
area: platform This involves updating, adding or removing a platform type: enhancement This is a feature request or a pull request that adds a feature type: refactor This refactors existing code

Comments

@LooFifteen
Copy link
Member

Confirmation

  • I have checked for similar issues.

Problem

Currently, when creating support for a Bukkit-based platform, BukkitChameleon must be extended to grant access to Bukkit's manager classes. If these managers begin to use the abstracted classes rather than the internals where possible, it'll be less hacky when adding a platform like this to Chameleon.

Suggested solution

Prefer abstract classes over internal implementation in managers.

Additional information

No response
@LooFifteen LooFifteen added type: enhancement This is a feature request or a pull request that adds a feature status: triage This issue is awaiting review labels Mar 30, 2023
@joshuasing joshuasing added type: refactor This refactors existing code and removed status: triage This issue is awaiting review labels Aug 31, 2023
@joshuasing joshuasing mentioned this issue Sep 1, 2023
Merged
5 tasks
@joshuasing joshuasing added the area: platform This involves updating, adding or removing a platform label Sep 8, 2023
@LooFifteen
Copy link
Member Author

This is solved, right?

@joshuasing
Copy link
Member

joshuasing commented Sep 14, 2023 •
edited
Loading

This is solved, right?

The Bukkit managers have been decoupled.
I meant to ask whether you also wanted other platforms decoupled (which I don't really see much of a reason to do this, right?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: platform This involves updating, adding or removing a platform type: enhancement This is a feature request or a pull request that adds a feature type: refactor This refactors existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuasing @LooFifteen