Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple versions of Sponge #170

Open
1 task done
joshuasing opened this issue Nov 24, 2022 · 0 comments
Open
1 task done

Support for multiple versions of Sponge #170

joshuasing opened this issue Nov 24, 2022 · 0 comments
Labels
contributor: needs feedback Feedback is wanted before these changes are merged platform: sponge status: future This might be done in the future type: enhancement This is a feature request or a pull request that adds a feature
Milestone
v1.0.0

Comments

@joshuasing
Copy link
Member

Confirmation

  • I have checked for similar issues.

Problem

Sponge seems to consistently and completely break their API between each version.
We currently only support Sponge v8, and even support for that is problematic and somewhat broken.

E.g. #118

Suggested solution

It might work to create several separate modules for sponge; e.g. platform-sponge7, platform-sponge8, platform-sponge9, however this is rather impractical and would take a lot of time and effort to maintain.
We could support only the latest version of Sponge, however that could cause problems for some developers.

If possible, we need to figure out a better solution or drop Sponge support entirely.

Additional information

No response
@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature status: triage This issue is awaiting review status: future This might be done in the future area: platform This involves updating, adding or removing a platform contributor: needs feedback Feedback is wanted before these changes are merged contributor: wanted and removed status: triage This issue is awaiting review labels Nov 24, 2022
@joshuasing joshuasing added this to the 1.0.0 milestone Nov 24, 2022
@joshuasing joshuasing added platform: sponge and removed contributor: wanted area: platform This involves updating, adding or removing a platform labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor: needs feedback Feedback is wanted before these changes are merged platform: sponge status: future This might be done in the future type: enhancement This is a feature request or a pull request that adds a feature
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@joshuasing