Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar sends engine_getClientVersionV1 request with invalid 4-byte DATA encoding #7217

Open
tersec opened this issue Nov 5, 2024 · 0 comments
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@tersec
Copy link

tersec commented Nov 5, 2024

Describe the bug

Nov  5 16:00:12.488 2024 REQUEST 
{
  "jsonrpc": "2.0",
  "id": 2,
  "method": "engine_getClientVersionV1",
  "params": [
    {
      "code": "LS",
      "name": "Lodestar",
      "version": "v1.22.0/1531b19",
      "commit": "1531b19"
    }
  ]
}

From snooper-engine on [email protected]

https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/identification.md#clientversionv1 documents that this commit is a

DATA, 4 bytes - first four bytes of the latest commit hash of this build e.g. fa4ff922

And https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/common.md#encoding specifies that:

Values of a field of DATA type MUST be encoded as a hexadecimal string with a 0x prefix matching the regular expression ^0x(?:[a-fA-F0-9]{2})*$.

Which 1531b19 does not match.

Expected behavior

Use correct DATA encoding

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

Lodestar network=testnet, version=v1.22.0/1531b19, commit=1531b19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

No branches or pull requests

1 participant