Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libp2p 2.x.x submitPoolAttestation api time increased #7199

Open
twoeths opened this issue Oct 26, 2024 · 3 comments
Open

libp2p 2.x.x submitPoolAttestation api time increased #7199

twoeths opened this issue Oct 26, 2024 · 3 comments
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Oct 26, 2024

Describe the bug

This is v1.23.0-rc.0, submitPoolAttestation is > 140ms while <=105ms on stable lg1k, this is 6h rate interval

Screenshot 2024-10-26 at 10 44 10

Expected behavior

we should maintain the same submitPoolAttestation to v1.22.0 as this will affect attestation performance

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.23.0-rc.0
@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Oct 26, 2024
@twoeths
Copy link
Contributor Author

twoeths commented Oct 26, 2024

this could be related to #7077 because it happened since Oct 11 when we get libp2p upgrade merged

Screenshot 2024-10-26 at 12 28 24

the above is from unstable 1k

@ChainSafe ChainSafe deleted a comment Oct 26, 2024
@wemeetagain wemeetagain mentioned this issue Oct 28, 2024
Merged
@wemeetagain
Copy link
Member

After reverting the js-libp2p upgrade:
Screenshot from 2024-10-28 12-19-46

@twoeths
Copy link
Contributor Author

twoeths commented Oct 29, 2024

Screenshot 2024-10-29 at 15 51 24

issue was resolved on unstable 1k
I'd leave the issue open for libp2p 2.x.x migration later

@twoeths twoeths changed the title v1.23.0-rc.0 submitPoolAttestation api time increased libp2p 2.x.x submitPoolAttestation api time increased Oct 29, 2024
@wemeetagain wemeetagain mentioned this issue Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wemeetagain @twoeths