Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual-stack adds tcp to discovery-addresses, does not list ip4 #7123

Open
yorickdowne opened this issue Oct 3, 2024 · 3 comments
Open

Dual-stack adds tcp to discovery-addresses, does not list ip4 #7123

yorickdowne opened this issue Oct 3, 2024 · 3 comments
Labels
meta-bug Issues that identify a bug and require a fix. scope-networking All issues related to networking, gossip, and libp2p.

Comments

@yorickdowne
Copy link

Describe the bug

Configure Lodestar for dual-stack v4/6. The eth/v1/node/identity route shows discovery_addresses correctly containing an ip6 udp port, but also the ip6 tcp port. The ip4 udp port is missing.

Expected behavior

discovery_addresses lists the ip4 and ip6 udp port. Afaik discovery is strictly udp in p2p, and all transport is tcp

Steps to reproduce

Run Lodestar on a dual-stack host with --listenAddress 0.0.0.0 --port ${CL_P2P_PORT:-9000} --listenAddress6 :: --port6 ${CL_IPV6_P2P_PORT:-9090} --enr.ip6 ${__public_v6}

Additional context

"discovery_addresses":["/ip6/2001:1234:5678:9abc::/tcp/9090","/ip6/2001:1234:5678:9abc::/udp/9090"] (actual ip6 redacted)

Operating system

Linux

Lodestar version or commit hash

v1.22.0/c26cc63

@yorickdowne yorickdowne added the meta-bug Issues that identify a bug and require a fix. label Oct 3, 2024
@wemeetagain
Copy link
Member

Thanks for reporting this, will take a look

@nflaig
Copy link
Member

nflaig commented Oct 3, 2024

@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

No branches or pull requests

5 participants
@wemeetagain @nflaig @philknows @yorickdowne and others