Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Media Queries #75

Closed
wants to merge 5 commits into from
Closed

Conversation

kmcmakin00
Copy link
Contributor

I am planning on using Media Queries that change the layout depending on screen size.

@kmcmakin00 kmcmakin00 linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@yashaswini-slu yashaswini-slu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can still see the same design for the footer
Screenshot 2024-02-25 at 16 08 25

Copy link
Collaborator

@yashaswini-slu yashaswini-slu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-18 at 11 11 55 we can improve this design

Copy link
Collaborator

@yashaswini-slu yashaswini-slu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add tooltip - helper text, user will get an idea of what that icon is for.
Screenshot 2024-03-18 at 11 14 38

@kmcmakin00 kmcmakin00 marked this pull request as ready for review April 30, 2024 20:02
Copy link
Collaborator

@yashaswini-slu yashaswini-slu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the branch with main branch

@kmcmakin00
Copy link
Contributor Author

Update the branch with main branch

My branch is up-to-date

Copy link
Member

@thehabes thehabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see a great deal of improvement in how the header/footer is handle as I move between device emulators, this is much better. I am impressed that both landscape and portrait mode were taken into account.

I can see the footer icons just did not want to line up for you in some cases. Using a "grid" technique may help this be more consistent. Remember that you have Chota CSS in the background, and using the row and column classes can do a lot of this as well. It is OK as-is, just leaving this note.

Galaxy S20+
image

Galaxy S8
image

I notice a lot of whitespace changes where the tab index has been changed that should be cleaned up. If you look at your diff, then apply the "hide whitespace changes" settings and see it again, you'll see how much "unchanged" code is affected (it is significant).

image

Make sure to resolve the conflicts (I think the whitespace is involved here.) I have noted some links to update and some cleanup items inline. Just some cleanup stuff to think about polishing this up before taking it forward.

public/components/layout.js Outdated Show resolved Hide resolved
public/components/layout.js Outdated Show resolved Hide resolved
public/components/layout.js Show resolved Hide resolved
public/components/layout.js Outdated Show resolved Hide resolved
public/components/layout.js Show resolved Hide resolved
public/stylesheets/style.css Show resolved Hide resolved
@kmcmakin00 kmcmakin00 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header/Footer On Small Screens
3 participants