Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43 browse glosses by field #44

Merged
merged 13 commits into from
Jul 22, 2024
Merged

43 browse glosses by field #44

merged 13 commits into from
Jul 22, 2024

Conversation

leandrumartin
Copy link
Contributor

I updated the data table components (DataTable.tsx, Columns.tsx, DataTableToolbar.tsx) to be more flexible to allow creation of new tables with different columns and different fields to search by. I then used this to create data tables for the "Browse by [Tag/Book/Theme]" pages.

@leandrumartin leandrumartin self-assigned this Jul 2, 2024
@leandrumartin leandrumartin linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gog-public-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:11pm

…Gallery-of-Glosses into 43-browse-glosses-by-field

Issue #43 depends on commits merged by Pull #48.
@leandrumartin
Copy link
Contributor Author

All Gloss browsing tables now display the Canonical Reference Locator. In addition, all tables are searchable via a query parameter, in preparation for the possibility of linking directly to searches as suggested in Issue #36.

@leandrumartin leandrumartin marked this pull request as ready for review July 11, 2024 16:14
@leandrumartin leandrumartin requested a review from cubap July 11, 2024 16:14
Copy link
Member

@cubap cubap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Filtering by subsection (so Matthew 9 but not Matthew 5) would be a nice addition.

@cubap cubap merged commit ec908f9 into main Jul 22, 2024
2 checks passed
@cubap cubap deleted the 43-browse-glosses-by-field branch July 22, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse Glosses by field
2 participants