Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show Card ID below images #2028

Open
proideo opened this issue Aug 6, 2024 · 4 comments
Open

Option to show Card ID below images #2028

proideo opened this issue Aug 6, 2024 · 4 comments
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented

Comments

@proideo
Copy link

proideo commented Aug 6, 2024

Hi. I think it would be nice to have an option to show the Card ID below the images like before.

Sometimes, the code generated based on the ID doesn't match the original and we have to use an image instead but keeping the ID below it.

Thanks.

@TheLastProject
Copy link
Member

The general design philosophy I follow is that the app should do the right thing out of the box and there should be as little options as possible. If an option is added, it needs to have a very good reason to exist. Basically, every time Catima gives you an option it has failed to make a good choice (and it complicates the codebase).

So, I'm going to need a good reason for this change. Why exactly do you need the combination of image + ID? What use case does this solve?

@proideo
Copy link
Author

proideo commented Aug 7, 2024

For now, I only have 5 cards in Catima but in two of them, the generated QR code does not match the original and I have to add it as an image. Before version 2.30, the ID was displayed below the image as an alternative but now we only have the text "front/back image" which cannot be edited.

I think that for some people the current text may be useful, but for other cases it would be interesting to have the option to edit it or to be able to choose to show the ID. This would provide an alternative if the image scan fails.

@TheLastProject
Copy link
Member

but in two of them, the generated QR code does not match the original and I have to add it as an image

Are you sure you have to use the image? This sounds like #939 where the QR code looks visually different because it has another error correction level when displayed in Catima but contains the exact same data. It's very very rare that any scanner cares about the error correction level being different.

but for other cases it would be interesting to have the option to edit it or to be able to choose to show the ID.

I really need more than "interesting" as a justification for adding a setting for something in Catima. As I tried to explain before, settings make the app more complex, both for me as the developer and for the user who has to navigate more settings in a more cluttered UI and has to spend more energy filtering out irrelevant info.

An ability to edit the text of the front and back image would perhaps make some sense, but it would also risk going against the idea in #1889. I agree that "Front image" and "Back image" currently aren't the most meaningful bits of text but it does help give context and is more flexible towards in the future adding more images/attachments and adds meaning to "front" or "back" (I've more than one been asked on the phone about something "on the back of the card", having the "Front/Back" text there helps to make sure I'm looking at the right thing). It however seems quite low-priority to me to add that and we would have to think the implementation through a lot to ensure that the custom text setup will scale when more files could be added later, so I'm not sure if it's worth the work or even makes sense as long as #1889 isn't implemented yet.

This would provide an alternative if the image scan fails.

I would much prefer actually fixing the cases where image scanning fails instead of spending time on complicating the codebase so users have more optional manual workarounds. The app should just work, users shouldn't have to bother with workarounds :)

@TheLastProject TheLastProject added state: consensus-needed A consensus needs to be reached before this can be implemented and removed state: needs info labels Aug 7, 2024
@proideo
Copy link
Author

proideo commented Aug 7, 2024

I would much prefer actually fixing the cases where image scanning fails instead of spending time on complicating the codebase so users have more optional manual workarounds. The app should just work, users shouldn't have to bother with workarounds :)

I understand. I will test if one of the generated codes works even if it is different from the original. I cannot test the other one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented
Projects
None yet
Development

No branches or pull requests

2 participants