Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Card ID for binary content? #1824

Open
leoheitmannruiz opened this issue Apr 10, 2024 · 2 comments
Open

Hide Card ID for binary content? #1824

leoheitmannruiz opened this issue Apr 10, 2024 · 2 comments
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: tolerable Low/no impact on users type: enhancement New feature or request

Comments

@leoheitmannruiz
Copy link

Hey :)

First off:
Thanks for all the great work!!
I used to just keep images of barcodes in my gallery, but Catima is soo much nicer.
Especially that the screen brightness is automatically set to max when viewing barcodes!


I've got an aztec barcode, whose content is binary gibberish.
I wonder if it makes sense not to show the content/card id below the barcode in such cases.
It seems desirable to me, as (in my case) half of the characters are weird and the other half aren't displayed correctly.
Not very pretty.
I might be missing something, but generally I don't see a point in showing binary data.

What do you think?

@TheLastProject
Copy link
Member

Yeah, it makes sense to hide binary. Just wondering what to do instead. Hide it completely? Show some text like "View barcode" you can still tap like with non-binary values?

And of course, detecting binary will be its own challenge.

@TheLastProject TheLastProject added type: enhancement New feature or request severity: tolerable Low/no impact on users common: occasional Affects or can be seen by some users regularly or most users rarely labels Apr 11, 2024
@leoheitmannruiz
Copy link
Author

Not sure either.

I'm tending towards having some text you can tap to show the Card ID.

Mainly to be consistent in having text under the barcode and in case someone
wants to compare the content of the barcode generated by Catima with the
original? Otherwise I don't really see a use case for showing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: tolerable Low/no impact on users type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants