Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent close and onClose event? #85

Open
hernandp-nimble opened this issue Jan 19, 2024 · 3 comments
Open

Prevent close and onClose event? #85

hernandp-nimble opened this issue Jan 19, 2024 · 3 comments

Comments

@hernandp-nimble
Copy link

It a lot of use cases we want to add functionality when closing as prevent the close whenever a condition is met.

@CaptainCodeman
Copy link
Owner

Can you provide more details - which component, and the scenario you'd want to prevent close?

@hernandp-nimble
Copy link
Author

Sorry for the lack of information, I was talking about the dialog. Also nested dialogs render inside each other and cannot be set to absolute if you have relative containers on top. I saw in other libraries they use Portals to manage this better, don't know if that can be a solution

@CaptainCodeman
Copy link
Owner

And what is the situation where the user wants to close a dialog, but the system should get to say "nuhuh"? IMO it should always be equivalent to a 'cancel' action.

I'm not a fan of nested dialogs, I think the UX should always be re-thought at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants