-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only include web.$(Configuration).config where xxxx exists on disk. Fixes #67 #68
base: main
Are you sure you want to change the base?
Conversation
I'll be pulling in a few PRs together, including #67 at a minimum to make it easier to do releases. |
@CZEMacLeod I know that I had originally proposed that the "Debug/Release/BindingRedirects" as Is it worth just simplifying the globbing of .Config files to something like this that contains a wildcard... so it will only ever pull in files that do exist on disk... and then update ones that we believe should not be placed in the puiblished/packages web application <ItemGroup Condition="'$(EnableWebFormsDefaultItems)'=='true'">
<_WebConfigConfiguration Include="$(Configurations)" />
<_WebConfigConfiguration Include="BindingRedirects" />
<Content Include="Web*.config" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
<Content Update="@(_WebConfigConfiguration->'Web.%(Identity).config')" >
<DependentUpon Condition="EXISTS('Web.config')">Web.config</DependentUpon>
</Content>
</ItemGroup> |
@leusbj Interesting idea.
Unfortunately, while I like the idea of using I did feel that there may be other uses for the All of that is out of scope for this PR though, but I wanted to explain my thought process. |
@CZEMacLeod No performance reason. Just wasn't sure if treating them differently was actually important anymore... and if it wasn't there might be a straight forward approach to glob them all |
@leusbj The thing is, you want the |
@CZEMacLeod Sorry for confusion. My phrase "treating them differently", was geared towards they don't need to be in different ItemGroups. That they could all be
In my mind the primary reason I had initially proposed putting the package/publish transformations as What you have looks to work (plus you have insight into the slow-cheetah ideas that I definitely didn't consider). |
Ensures that web.*.config files automatically included in None for each configuration, actually exist on disk to prevent missing files showing in the solution tree and issues with TVFS.
This should resolve #67