Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VISSR version #59

Open
5 tasks done
slawr opened this issue Nov 15, 2024 · 2 comments · May be fixed by #64
Open
5 tasks done

Update VISSR version #59

slawr opened this issue Nov 15, 2024 · 2 comments · May be fixed by #64
Assignees
Labels
enhancement New feature or request task Task not fitting other labels, e.g. project ops

Comments

@slawr
Copy link
Collaborator

slawr commented Nov 15, 2024

CDSP last updated the VISSR version it uses several months ago, whilst the upstream project has continued to evolve. We should look to update to the latest version.

High level task outline:

  • Decide VISSR version and create summary of likely code impact (required changes)
  • Update submodule and version used in docker
  • Sanity test VISSR operation, including with IoTDB
  • Update CDSP documentation where necessary

VISSR upstream tasks:

  • Send fix for dockerfile related to protobuf dir copy

Input notes:

  1. @UlfBj has provided the following helpful note about a change in behavior:

I saw the following in your text
You can query what VSS nodes the server understands by asking for the VSS path list using the URL http://localhost:8081/vsspathlist. Entering that URL in your web browser will typically give you a graphical rendering of the JSON data returned.
This is true for VISSRv2.0 (on the v2.0 branch) but not for VISSRv3.0 (on master branch) where I had to diable it due to the new multitree support (it could be restored).

Implementation notes

52.78 server/vissv2server/grpcMgr/testprocess/gRPCClient.go:17:21: undefined: utils.Compression
52.78 server/vissv2server/grpcMgr/testprocess/gRPCClient.go:49:15: undefined: pb.NewVISSv2Client
52.78 server/vissv2server/grpcMgr/testprocess/gRPCClient.go:54:58: too many arguments in call to utils.SubscribeRequestJsonToPb
52.78 	have (string, unknown type)
52.78 	want (string)
  • Docker runtime
    • Startup fails due to missing viss.him. Investigation revealed other new runtime files required.
  • Docker issues resolved upstream in PR Dockerfile.rlserver: update vissv2server target for VISSR v3 vissr#79. See PR for details.
  • Documentation
    • Added VISS/VISSR examples to online doc examples page
    • Updated Docker readme.md to reflect VISSR v3 changes.
@slawr slawr self-assigned this Nov 15, 2024
@slawr slawr converted this from a draft issue Nov 15, 2024
@slawr slawr added enhancement New feature or request task Task not fitting other labels, e.g. project ops labels Nov 15, 2024
@slawr
Copy link
Collaborator Author

slawr commented Nov 29, 2024

@UlfBj has helpfully pointed out that VISSR now has a hello-world example here https://covesa.github.io/vissr/build-system/hello-world/. We should point to it in CDSP examples list in the documentation site. I mention it here as we should first check whether it needs VISSRv3, i.e. whether we need to do this update first.

@slawr slawr moved this from Next to In Progress in Central Data Service Playground Dec 11, 2024
@slawr slawr linked a pull request Jan 17, 2025 that will close this issue
@slawr
Copy link
Collaborator Author

slawr commented Jan 17, 2025

Upstream VISSR work was clarified in VISS/VISSR Slack channel with maintainers. Changes have been merged upstream and integrated downstream in CDSP. CDSP now uses VISSR latest commit. CDSP doc also updated.

All tasks complete. Changing WIP status from WIP to ready for review/merge.

@slawr slawr linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task Task not fitting other labels, e.g. project ops
Projects
Development

Successfully merging a pull request may close this issue.

1 participant