You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Proper OpSec requires expiring OAuth tokens -> Expiring OAuth tokens means needing to update CMake toolchains entirely too often. Luckily, every GH Repo can be accessed via SSH (https://github.com/REPO -> [email protected]:REPO) which allows us to use our super-secret-ssh-key to access private repositories without the headache!
Seems that you've thought about this based on the comments, but no solution other than manual specification of the URL as an SSH URL is possible at this time. As there's a one-to-one with (default) HTTPS/SSH access to GH, it might make sense to enable this with a simple toggle
Describe the solution you'd like
Having an option (e.g. CMAIZE_GITHUB_USE_SSH) to switch to SSH GH access would be desireable. I've done this locally via addition of the following to CMaize/cmake/cmaize/package_managers/cmake/dependency/github.cmake after URL discovery:
if ( _bd_private AND CMAIZE_GITHUB_USE_SSH )
string(REPLACE "github.com/" "${CMAIZE_GITHUB_SSH_PREFIX}:" _bd_url "${_bd_url}")
endif( )
where CMAIZE_GITHUB_SSH_PREFIX defaults to [email protected]. If this is a sufficient fix, I'll PR it, if there's more that would need to be done infrastructurally, this is meant to start the discussion.
The text was updated successfully, but these errors were encountered:
Is the idea that you would be able to enable this CMAIZE_GITHUB_USE_SSH toggle from the command line (-DCMAIZE_GITHUB_USE_SSH=ON) or the toolchain file? I like that idea, since you don't have to modify every CMakeLists.txt file to use the SSH versions of the repo URLs anymore.
It would be awesome if you would get a PR started! As for the PR, CMAIZE_GITHUB_USE_SSH and CMAIZE_GITHUB_SSH_PREFIX should be defined and documented in cmake/cmaize/globals.cmake, which is in alphabetical order aside from the two project variables that are grouped together.
Is your feature request related to a problem? Please describe.
Proper OpSec requires expiring OAuth tokens -> Expiring OAuth tokens means needing to update CMake toolchains entirely too often. Luckily, every GH Repo can be accessed via SSH (
https://github.com/REPO
->[email protected]:REPO
) which allows us to use oursuper-secret-ssh-key
to access private repositories without the headache!Seems that you've thought about this based on the comments, but no solution other than manual specification of the
URL
as an SSH URL is possible at this time. As there's a one-to-one with (default) HTTPS/SSH access to GH, it might make sense to enable this with a simple toggleDescribe the solution you'd like
Having an option (e.g.
CMAIZE_GITHUB_USE_SSH
) to switch to SSH GH access would be desireable. I've done this locally via addition of the following toCMaize/cmake/cmaize/package_managers/cmake/dependency/github.cmake
after URL discovery:where
CMAIZE_GITHUB_SSH_PREFIX
defaults to[email protected]
. If this is a sufficient fix, I'll PR it, if there's more that would need to be done infrastructurally, this is meant to start the discussion.The text was updated successfully, but these errors were encountered: