Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dependency Warnings #101

Open
ryanmrichard opened this issue Apr 19, 2023 · 0 comments
Open

[BUG] Dependency Warnings #101

ryanmrichard opened this issue Apr 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ryanmrichard
Copy link
Collaborator

Describe the bug
This is low priority, but when I build NWChemEx I see warnings from compiling dependencies.

To Reproduce
Build NWChemEx and look at the build output.

Expected behavior
Traditionally warnings for dependencies are suppressed in build logs, since it's not the current project's fault the dependency doesn't compile cleanly.

Additional context
IIRC CMake automatically suppresses warnings for dependencies if they are marked as private dependencies. It may be the case that we need to introduce a PRIVATE_DEPENDS key for cmaize_add_library in order to distinguish between public/private dependencies.

@ryanmrichard ryanmrichard added the bug Something isn't working label Apr 19, 2023
@ryanmrichard ryanmrichard changed the title [BUG] Squash this please!!!! [BUG] Dependency Warnings Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant