Fixing lint errors and adjusting CI test scope #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyanuja
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Noticing an error in a test failing that looks like a schema mismatch error, the API is returning more data than what's declared in its schema definition and I think its because of the new property that has been added to the API response (isEnglish I believe)
going to approve so I can pull changes and debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because in P3 we added StandardJS, we had two competing lint standards that could never pass together. This led to failures on the main branch and made it hard to debug newly introduced lint errors.
I changed the StandardJS lint to only run on one file, and changed ESLint to run on all files other than that file. So now it's possible for both tests to simultaneously pass.
I also modified all files so that the lint tests ARE simultaneously passing, and added some extra error handling in the new translation feature.
Resolves #53