forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Answer Dropdown Toggle to Topics #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I edited the theme to add a dropdown button that can toggle the topic as answered or unanswered. It currently uses the lock/unlock backend.
Pull Request Test Coverage Report for Build 11286207955Details
💛 - Coveralls |
katcday
added
the
Question Answered Functionality
These issues relate to the ability to mark questions as answered/closed.
label
Oct 11, 2024
KesterTan
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Question Answered Functionality
These issues relate to the ability to mark questions as answered/closed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon starting this, I realized that I had done the backend for posts which I thought were topics. At this point I redid the entire backend for topics and figured out the frontend.
TESTING
Screen.Recording.2024-10-11.at.1.11.42.AM.mov
This closes:
#resolve #2
#resolve #11
#resolve #5