Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge individual changes made in Project 1 #12

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Merge individual changes made in Project 1 #12

merged 1 commit into from
Sep 20, 2024

Conversation

shinyumh
Copy link

Merging changes made in project 1 (refactoring src/messaging/rooms.js) to this team repo

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10873943640

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.666%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/messaging/rooms.js 10 12 83.33%
Totals Coverage Status
Change from base Build 10784039634: 0.0%
Covered Lines: 22322
Relevant Lines: 25582
💛 - Coveralls

@bencondemi bencondemi self-requested a review September 20, 2024 17:15
bencondemi
bencondemi approved these changes Sep 20, 2024
View reviewed changes
Copy link

@bencondemi bencondemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@shinyumh shinyumh merged commit b859768 into f24 Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencondemi bencondemi bencondemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shinyumh @coveralls @bencondemi