-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL improvements #38
Comments
Happy to help on this. Important note is that you must test using a real RTL language and not just set english to be rtl in the xml |
Cheers Brian. Glad you mentioned that, as I was going to do the later |
yeah the problem with the latter is that the language itself is encode as LTR and then you get some really weird results. Especially when it comes to punctuation at the end of lines. It's the number one issue I hear regularly from developers who have to work with rtl |
Started: e72d2ad
Rebuilds the 2 main CSS files with an |
More RTL improvements done with logical properties: 5d14801 Just waiting for Safari to catch up!! |
Not tested on RTL yet but will definitely need fixes.
Will go with a separate CSS file and proper mixins rather than Atum's approach.
Need to look into what browsers already handle other than text alignment. That fact we don't support IE11 should make life a little easier.
The text was updated successfully, but these errors were encountered: