Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL improvements #38

Open
C-Lodder opened this issue Dec 31, 2019 · 5 comments
Open

RTL improvements #38

C-Lodder opened this issue Dec 31, 2019 · 5 comments

Comments

@C-Lodder
Copy link
Owner

Not tested on RTL yet but will definitely need fixes.

Will go with a separate CSS file and proper mixins rather than Atum's approach.

Need to look into what browsers already handle other than text alignment. That fact we don't support IE11 should make life a little easier.

@brianteeman
Copy link
Collaborator

Happy to help on this.

Important note is that you must test using a real RTL language and not just set english to be rtl in the xml

@C-Lodder
Copy link
Owner Author

C-Lodder commented Jan 1, 2020

Cheers Brian. Glad you mentioned that, as I was going to do the later

@brianteeman
Copy link
Collaborator

yeah the problem with the latter is that the language itself is encode as LTR and then you get some really weird results. Especially when it comes to punctuation at the end of lines. It's the number one issue I hear regularly from developers who have to work with rtl

@C-Lodder
Copy link
Owner Author

C-Lodder commented Jan 2, 2020

Started: e72d2ad

  • Fixes sidebar menu
  • Fixes text alignment
  • Create some core mixins to cater for some CSS properties (wish browsers would just deal with this automatically)
  • Remove some unecessary IE code from reboot.scss

Rebuilds the 2 main CSS files with an -rtl suffix and dynamically setting $rtl: true;

@C-Lodder
Copy link
Owner Author

C-Lodder commented Apr 9, 2020

More RTL improvements done with logical properties: 5d14801

Just waiting for Safari to catch up!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants