xgc/res protocol / data size mismatch

[mariusbu]

Hi,

Calling res.QueryClientIds(conn, 1, specs).Reply() will crash due to an old bug in xcb/proto/src/res.xml.
The problem is located here:

xgb/res/res.go

Line 170 in 27f1227

v.Value[i] = xgb.Get32(buf[b:])

The ClientIdValue.Length we get from the server indicates the length in bytes, but the loop reads CARD32s.

The bug has been fixed in the protocol description (see https://cgit.freedesktop.org/xcb/proto/commit/?id=f7948e355d85624c577d0fa63977b3bed4d6024f), but the X-Resource bindings will have to be re-generated from the updated res.xml (or edited manually) to fix this.