-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in reader #293
Comments
Good catch. Patches welcome. Note that this error is impossible to trigger though, because the number of classes is always quite small and there is no way to make it bigger. |
Yes, that's right. This issue was found by my colleage who just has no github account, so I'd written instead of him, and so I hardly supply a patch (Alas, don't know Rust). But. I have a side question: do you have benchmark statistics of this csv-reader on some of CSV-files (game.csv, for example). Could you give me a link? |
You can run benchmarks with |
Possible error in code: file reader.rs
Check code if self.next_class = 255
existing code:
if self.next_class > CLASS_SIZE {
probably should be:
if self.next_class >= CLASS_SIZE {
May use controlled conversion to u8:
The text was updated successfully, but these errors were encountered: