From d4657644f45507108e795b254c04db2c8677c925 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Fri, 4 Nov 2022 16:33:19 +0000 Subject: [PATCH] vuln-fix: Partial Path Traversal Vulnerability This fixes a partial path traversal vulnerability. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: Medium CVSSS: 6.1 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 Co-authored-by: Moderne --- .../src/main/java/org/primefaces/util/FileUploadUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/primefaces/src/main/java/org/primefaces/util/FileUploadUtils.java b/primefaces/src/main/java/org/primefaces/util/FileUploadUtils.java index e442fdd6f6..83cc6b9942 100644 --- a/primefaces/src/main/java/org/primefaces/util/FileUploadUtils.java +++ b/primefaces/src/main/java/org/primefaces/util/FileUploadUtils.java @@ -114,7 +114,7 @@ public static String getValidFilePath(String filePath) throws ValidationExceptio if (!parentFile.isDirectory()) { throw new ValidationException("Invalid directory", "Invalid directory, specified parent is not a directory."); } - if (!file.getCanonicalPath().startsWith(parentFile.getCanonicalPath())) { + if (!file.getCanonicalFile().toPath().startsWith(parentFile.getCanonicalFile().toPath())) { throw new ValidationException("Invalid directory", "Invalid directory, \"" + file + "\" does not inside specified parent."); }