Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Players with the same name #53

Open
BruceJohnJennerLawso opened this issue Oct 4, 2016 · 4 comments
Open

Different Players with the same name #53

BruceJohnJennerLawso opened this issue Oct 4, 2016 · 4 comments

Comments

@BruceJohnJennerLawso
Copy link
Owner

Case in point can be seen by running

python playerSummary.py nhl "Taylor Hall"

Which wouldnt be that big of a deal, except that the nhl player object counts both 80s hall and 2010s Taylor Hall seasons together for the player career summaries.

Also, I think theres a pair of Greg Adams on the 90s Canucks, and probably more cases of multiple-players-to-a-name

@BruceJohnJennerLawso
Copy link
Owner Author

BruceJohnJennerLawso commented Oct 4, 2016

A decent solution for this would be to write a script that manually modifies the data scraped right after the scraper runs and manually changes the name something like

"Taylor Hall"

to

"Taylor Hall (born 1991)"

and

"Taylor Hall (born 1964)"

@BruceJohnJennerLawso
Copy link
Owner Author

This would be a good solution because it should allow for keeping up with any future changes to how the scraper works that might require updates to the csv files

@BruceJohnJennerLawso
Copy link
Owner Author

Maybe even easier to do, just tweak the scraper to save the player id that hockey reference uses, then save it right after the players full name, ie

http://www.hockey-reference.com/players/h/hallta02.html

becomes Taylor Hall,hallta02

and a different one

Taylor Hall,hallta01

@BruceJohnJennerLawso
Copy link
Owner Author

as mentioned in #93, #109 just made fixing this a hell of a lot harder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant