Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove button from control view #340

Open
2 of 3 tasks
geclick opened this issue Sep 23, 2021 · 0 comments
Open
2 of 3 tasks

Remove button from control view #340

geclick opened this issue Sep 23, 2021 · 0 comments

Comments

@geclick
Copy link

geclick commented Sep 23, 2021

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

BMPlayer version

Installed with

  • Carthage
  • Cocoapods

Issue Description

What

I need to remove the full screen button, but the only way for doing this is creating a custom controlView subclassing BMPlayerControlView. If the controlView attribute of BMPlayer wasn't private, someone can access the fullscreenButton and remove it from his superview, or set the controlView directly. I added the player via IB so I wouldn't have to reinitialize it or setting constraints using SnapKit

Reproduce

[The steps to reproduce this issue. What is the URL you were trying to play, where did you put your code, etc.]

Other Comment

[Add anything else here]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant