Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most example links are broken #925

Open
apophis51 opened this issue Jan 21, 2024 · 4 comments
Open

Most example links are broken #925

apophis51 opened this issue Jan 21, 2024 · 4 comments
Labels

Comments

@apophis51
Copy link

Most Example Links are broken

Most Brain.js example links are broken
It looks like the issue stems from /master/examples/ folder having been deleted on the current branch

-Forcasting
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/BrainJS/brain.js/blob/master/examples/javascript/predict-numbers.js

-Maths
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/BrainJS/brain.js/blob/master/examples/javascript/learn-math.js

-CrossValidate
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/BrainJS/brain.js/blob/master/examples/javascript/cross-validate.js

-GpuAI
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/BrainJS/brain.js/blob/master/examples/javascript/gpu.html

-Cryotherapy
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/iSumitBanik/Cryotherapy-Success-Rate

-RockPaperScissors
example link is broken on https://brain.js.org/#/examples which should go to:
https://github.com/arifikhsan/batu-gunting-kertas-nuxt

The GitHub repo mentions https://github.com/BrainJS/brain.js-examples/blob/main/src/cross-validate.ts as a source. so maybe updating the links or changing the source will fix the issue

@apophis51 apophis51 added the bug label Jan 21, 2024
@robertleeplummerjr
Copy link
Contributor

Open a PR?

@apophis51
Copy link
Author

will do!

@robertleeplummerjr
Copy link
Contributor

A rockstar pledge.

@apophis51
Copy link
Author

Ok so to update: it looks like this commit --> chore: Move examples, fix typescript output is the one that broke the example links because it looks like everything was moved to brain.js-examples. I'm getting ready to post my pull request to the Brainjs brain.js.org so that the website can now point to the correct links again. All I did was edit the 'strore' file with 5 updated url fixes. However, there is one other issue... It looks like when the examples were moved only the typescript examples were moved and not the js ones. So I'm only able to link to the typescript version. I think maybe that might have just been an oversite but then that would require an additional pull request to that other repo. For now, I think we can have the website pointing to the typescript versions so that the examples are at least not broken... If we want to reinclude the js versions, we would need an additional pull to add the js ones back, and maybe just have links to both of them on the example page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants