Pagination @adithya14255 @marudhu2004 #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not intuitive. Needs appropriate spacing |
|
This was the display when NO PAGINATION was in effect. But when pagination is in progress, this information should be different or presented and formatted differently. |
|
Two additional links required:
|
|
I have given three different suggestions/modifications. Each one of them can be posted as a separate issue, and specific PRs to be generated for each of them. |
|
Number of messages to be displayed per page can be increased to 25 |
|
Good speed improvement! Well done @Adithya14255 @marudhu2004 @Pavithratrdev |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #272
I @Adithya14255 and @marudhu2004 have done the following:
[x] added the issue number for which this pull request is created.
[x] added pagination for inbox
[x] ensured that search feature works with the new changes
[x] handled bad requests which might come with page count (negative pages, above page limit) by returning 404
[x] added custom 404 page
futher by @Adithya14255
[x] pagination with search
[x] clear button to remove searched string
[x] fixed some issues with using same route for both search and normal
[x] fixed some session problems
[x] page change only visible when more than 1 page exists
[x] fixed issue when new login leads to error page
@Pavithratrdev, please let me know about this update.