Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support building 64-bit Windows binaries #259

Open
PiRK opened this issue Jan 5, 2023 · 0 comments
Open

support building 64-bit Windows binaries #259

PiRK opened this issue Jan 5, 2023 · 0 comments

Comments

@PiRK
Copy link
Collaborator

PiRK commented Jan 5, 2023

See spesmilo#6598 for one good reason.

Another good reason is that some python lib devs are no longer building win32 wheels, so when we bump the python version we will start seeing issues with some libraries having to be compiled.
For instance pyscard stopped shipping win32 wheels starting with v2.0.1, which is a problem because v2.0.0 did not ship a python3.9 wheel for MacOS and v2.0.1 no longer ships a python 3.8 wheel for MacOS, so bumping python to 3.9 for binaries is going to be tricky (dependency on swig to compile pyscard) if we don't support 64-bit windows soon.

PiRK added a commit that referenced this issue Jan 9, 2023
… env var

Partial backport of spesmilo@f1f584c

related to  #259 but does not address it entirely: the win64 build still fails due to an OpenSSL compilation error

Test Plan:
```
WIN_ARCH=win32 GIT_REPO=`pwd` contrib/build-wine/build.sh HEAD
WIN_ARCH=win64 GIT_REPO=`pwd` contrib/build-wine/build.sh HEAD
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@PiRK and others