Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lint] move same line comments to previous line #248

Open
PiRK opened this issue Dec 10, 2022 · 0 comments
Open

[lint] move same line comments to previous line #248

PiRK opened this issue Dec 10, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PiRK
Copy link
Collaborator

PiRK commented Dec 10, 2022

Same line comments make it harder to find changes to code with git blame, and they interfere with black code formatting.
@PiRK PiRK added enhancement New feature or request good first issue Good for newcomers labels Dec 10, 2022
@PiRK PiRK mentioned this issue Dec 13, 2022
Closed
8 tasks
PiRK added a commit that referenced this issue Dec 21, 2022
@PiRK
[StatusBar] move network status tips and icons to statusbar.py
7f0a4dd 
This is all StatusBar business, so we can remove it from the overweight main_window.py.
Modernize and refactor the code by using enums instead of dicts.

Fix a couple of same line comments in nearby lines (#248) to improve formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PiRK