Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxSEA #3627

Open
10 tasks done
feargalr opened this issue Oct 28, 2024 · 6 comments
Open
10 tasks done

TaxSEA #3627

feargalr opened this issue Oct 28, 2024 · 6 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place ERROR

Comments

@feargalr
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @feargalr

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: TaxSEA
Type: Package
Title: Taxon Set Enrichment Analysis
Version: 0.99.0
Authors@R: c(person("Feargal", "Ryan", 
    email = "[email protected]", 
    role = c("aut", "cre"),comment = c(ORCID = "0000-0002-1565-4598")))
Description: TaxSEA is an R package for Taxon Set Enrichment Analysis, which 
    utilises a Kolmogorov-Smirnov test analyses to 
    investigate differential abundance analysis output for whether there
    are alternations in a-priori defined sets of taxa from five previously 
    published databases (BugSigDB, MiMeDB, GutMGene, mBodyMap and GMRepoV2). 
    TaxSEA takes as input a list of taxonomic identifiers (e.g. species names, 
    NCBI IDs etc.) and a rank (E.g. fold change, correlation coefficient). 
    TaxSEA be applied to any microbiota taxonomic profiling technology 
    (array-based, 16S rRNA gene sequencing, shotgun metagenomics & 
    metatranscriptomics etc.) and enables researchers to rapidly contextualize 
    their findings within the broader literature to accelerate interpretation 
    of results.
License: GPL-3
Encoding: UTF-8
LazyData: false
VignetteBuilder: knitr
RoxygenNote: 7.2.3
biocViews: Microbiome, Metagenomics, Sequencing, GeneSetEnrichment, RNASeq
URL: https://github.com/feargalr/taxsea
BugReports: https://github.com/feargalr/taxsea/issues
Suggests:
    knitr,
    rmarkdown
Imports:
    ggplot2,
    stats,
    utils

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Oct 28, 2024
@lshep
Copy link
Contributor

lshep commented Nov 21, 2024

Please get rid of the empty export in the namespace

Plesae change the name of the vignette file to something more meaningful than
my-vignette generic names are not recommended to avoid load conflicts. We
recommend the name of the package TaxSEA.Rmd.

@lshep lshep added the pre-check passed pre-review performed and ready to be added to git label Nov 21, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Nov 22, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): TaxSEA_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/TaxSEA to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Nov 27, 2024
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

@feargalr
Copy link
Author

feargalr commented Dec 9, 2024

Thanks BioC team. A query about one of the warnings. This package is designed to complement several existing BioC packages (e.g. bugsigdbr, ANCOMBC etc.) but it doesn't depend on them as it has other standalone functionality too. However, I get a warning in the check. I wanted to ask how you'd like me to handle that? I could list a package as a dependency, although as an enhance might be more accurate? Thanks!

"WARNING: No Bioconductor dependencies detected. Note that some infrastructure
packages may not have Bioconductor dependencies. For more information, reach
out to the Bioconductor community and/or consider a CRAN submission."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place ERROR
Projects
None yet
Development

No branches or pull requests

4 participants