Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUCova #3620

Open
10 tasks done
astaburuaga-garcia opened this issue Oct 21, 2024 · 4 comments
Open
10 tasks done

RUCova #3620

astaburuaga-garcia opened this issue Oct 21, 2024 · 4 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@astaburuaga-garcia
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @astaburuaga-garcia

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: RUCova
Title: Removes unwanted covariance from mass cytometry data 
Version: 0.99.0
Authors@R: person("Rosario", "Astaburuaga-García", , "[email protected]", role = c("aut", "cre"), comment = c(ORCID = "0000-0003-1179-4080"))
Description: Mass cytometry data is high dimensional and contains unwanted covariance induced by variations in cell size, staining and other technical artefacts. This package uses a set of linear models to model and remove unwanted covariance from this data.   
License: use_gpl3_license()
Encoding: UTF-8
biocViews: Software, SingleCell
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
Suggests: 
    knitr,
    rmarkdown,
    BiocManager
Imports:
    dplyr,
    tidyr,
    fastDummies,
    ggcorrplot,
    ggh4x,
    ggplot2,
    ggpubr,
    ggridges,
    stringr,
    tibble,
    Matrix,
    ComplexHeatmap,
    grid,
    remotes,
    circlize,
VignetteBuilder: knitr
Depends: 
    R (>= 2.10)
LazyData: true

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Oct 21, 2024
@lshep lshep added the Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows label Oct 25, 2024
@lshep lshep removed the Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows label Nov 8, 2024
@lshep
Copy link
Contributor

lshep commented Nov 14, 2024

Please update you DESCRIPTION for a valid license field.

You mention mass cytometry but I don't see an integration with our common
Bioconductor class
for this data Spectra. Please provide interoperability with
this class.

Please remove commented out sections of vignette

@lshep lshep added 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Nov 14, 2024
@astaburuaga-garcia
Copy link
Author

astaburuaga-garcia commented Nov 25, 2024

Please update you DESCRIPTION for a valid license field.

Updated.

You mention mass cytometry but I don't see an integration with our common Bioconductor class for this data Spectra. Please provide interoperability with this class.

Our package works for mass cytometry data, not mass spectrometry (Spectra).

Please remove commented out sections of vignette

Done

@lshep
Copy link
Contributor

lshep commented Nov 27, 2024

It still seems like this could interact with common Bioconductor classes like a SummarizedExperiment and flowSet? You can see HDCytoData for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants