Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add r-saige and regenie from bioconda #392

Open
matuskosut opened this issue Nov 23, 2020 · 17 comments
Open

Add r-saige and regenie from bioconda #392

matuskosut opened this issue Nov 23, 2020 · 17 comments
Assignees
@ypriverol
Labels
bug

Comments

@matuskosut
Copy link

Hi all,

I would like to add bioconda containers for r-saige and regenie. I am not so sure how the relation between biocontainers and bioconda works. Do I have to make Dockerfiles and pull requests to this repository? or are you able to use the containers from quay?

https://quay.io/repository/biocontainers/r-saige?tab=tags
https://quay.io/repository/biocontainers/regenie?tab=tags

Biocontainers link shows empty result so far:
@osallou
Copy link
Contributor

osallou commented Nov 23, 2020

Hi,
If there is a bioconda package, containers are automatically created and pushed to quay.io and integrated to "biocontainers"

@matuskosut
Copy link
Author

matuskosut commented Nov 23, 2020 •
edited

Hi @osallou

what does that mean in practice on biocontainers side? Should I be able to query names of those packages in registry? (https://biocontainers.pro/#/registry) I have added both of those packages to bioconda just a few weeks ago, and if you check those biocontainers URLs they don't seem to include anything and it doesn't appear in registry search either. Am I misunderstanding something here?

@osallou
Copy link
Contributor

osallou commented Nov 23, 2020

nope, should appear in registry after merge in bioconda

@ypriverol do registry updates are ok?

@ypriverol
Copy link
Member

I will have a look today !!!

@matuskosut
Copy link
Author

@ypriverol thanks for joining, hope you will manage to solve it

@matuskosut
Copy link
Author

@ypriverol @osallou maybe you could have some pointers where I could look to help solving this?

@osallou
Copy link
Contributor

osallou commented Dec 8, 2020

Hum thanks, but it is on your backend that fetch info from docker/conda repos. Yasset manages it don t think you can easilly fix the issue and pricess to fetch data is quite long.

@ypriverol some news on issue?

@fullama
Copy link

fullama commented Dec 17, 2020

..i was just about to open a similar issue.. I added the first version of GUNC 2 months ago but it still doesn't appear in the biocontainers registry.. it seems that nothing new is being added right now? it also looks like no new updates for tools that are already in there are appearing..

the containers are built though, i can see them on quay.io for example, so it might be just whatever pulls the info into the website that has stopped working?

@osallou
Copy link
Contributor

osallou commented Dec 17, 2020

sorry for this, I am trying to contact person in charge of registry

@ypriverol
Copy link
Member

We are trying to fix the bug. Will be back to you soon.

@ypriverol ypriverol self-assigned this Dec 17, 2020
@ypriverol ypriverol added the bug label Dec 17, 2020
@chakrabandla
Copy link

chakrabandla commented Dec 17, 2020 •
edited

Something is wrong with the biocontainers organization in Quay.

Trying to fetch the biocontainers organization returns 504

https://quay.io/organization/biocontainers

Using API:

$ curl "https://quay.io/api/v1/repository?last_modified=true&namespace=biocontainers&popularity=true&public=true"                                
<html>
<head><title>504 Gateway Time-out</title></head>
<body bgcolor="white">
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.12.1</center>
</body>
</html>

fetching from other Quay organizations works well

https://quay.io/organization/bitnami

Using API:
curl https://quay.io/api/v1/repository?last_modified=true&namespace=bitnami&popularity=true&public=true

May be biocontainers has too many entries to fetch

@fullama
Copy link

fullama commented Dec 17, 2020

you are probably right there, if you leave out the last_modified parameter it returns before the query times out:

curl "https://quay.io/api/v1/repository?namespace=biocontainers&popularity=true&public=true"

{"repositories": [{"kind": "image", "name": "coreutils", "namespace": "biocontainers", "state": null, "is_public": true, "description": "# Coreutils\n\n> The gnu core utilities are the .........

@chakrabandla
Copy link

chakrabandla commented Dec 17, 2020 •
edited

Thanks @fullama. Removed that last_modified parameter from the pipeline. Hopefully the issue should be fixed after the pipeline finishes in couple of hours

Also, I wrote an email to Quay support. Hopefully they will address the issue.

@osallou
Copy link
Contributor

osallou commented Dec 17, 2020 via email

@fullama
Copy link

fullama commented Dec 17, 2020

Well at least it seems to work for now.. its not a long term solution by any means but the packages that have been mentioned here have appeared.. so success! :) - thanks for sorting it out.. its very appreciated

the quay.io api doesnt seem to offer pagination in their API: https://docs.quay.io/api/swagger/#!/repository/listRepos
..at least not that i can see.. :-/

@ypriverol
Copy link
Member

We will contact quay.io team to find a better solution

@osallou
Copy link
Contributor

osallou commented Dec 17, 2020

@fullama seems there is a next_page (or kind) parameter , don't know for limit per page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ypriverol ypriverol

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ypriverol @osallou @fullama @matuskosut @chakrabandla