workbench.colorCustomizations properties need updating

[johnnyschneider]

Background Context

I wrote a JS script to pull in exclusively the Atom One Dark theme in it's stock config, and then parse the JSON results into their respective tokenColorCustomization, semanticTokenColorCustomization, and workbench.colorCustomization fields. I did this because I didn't want to pull in an extra extension with a bunch of themes I will never use. I also wanted to learn a lot more about custom theming in editors, and learn some JS. I have my own personal color preferences but One Dark Pro was a good starting point to build my theme off of.

Describe the bug

When copying the properties from https://github.com/Binaryify/OneDark-Pro/blob/master/themes/OneDark-Pro.json VS Code notified me that these properties

"editorOverviewRuler.addedBackground": "#109868",
"editorOverviewRuler.deletedBackground": "#9A353D",
"editorOverviewRuler.modifiedBackground": "#948B60",
"editorGroup.background": "#181a1f",
"welcomePage.buttonHoverBackground": "#404754"

are outright not allowed.

Property editorOverviewRuler.addedBackground is not allowed.
Property editorOverviewRuler.deletedBackground is not allowed.
Property editorOverviewRuler.modifiedBackground is not allowed.
Property editorGroup.background is not allowed.

It notified me that these two properties

"editorIndentGuide.activeBackground": "#c8c8c859",
"editorIndentGuide.background": "#3b4048",

are deprecated.

'editorIndentGuide.activeBackground' is deprecated. Use 'editorIndentGuide.activeBackground1' instead.
'editorIndentGuide.background' is deprecated. Use 'editorIndentGuide.background1' instead.

To Reproduce

Hardcode the One Dark Pro Theme into settings.json

Expected behavior

No settings generated by One Dark Pro highlighted in settings.json

Screenshots & Example Code

Desktop (please complete the following information):

• OS: macOS Sonoma 14.7
• VSCODE Version: 1.95.0
• Theme version: master branch

Additional context

I expect the issue could be present in other themes. My script currently only works on the 4 themes found in the /themes folder. Please let me know if you need me to modify it to consume the themes inside src/themes/data. Gist with my script is here https://gist.github.com/johnnyschneider/f028986f4477b5f61fb3f3df17aba23a

[Binaryify]

thank for the reminder