Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlbumList view query is very slow #12

Open
gryphonmyers opened this issue Jun 16, 2023 · 2 comments
Open

AlbumList view query is very slow #12

gryphonmyers opened this issue Jun 16, 2023 · 2 comments

Comments

@gryphonmyers
Copy link

The AlbumList view is quite slow to render, stemming from the fact that the handler pulls ALL albums out of the Beets DB then does pagination in memory. For large libraries, it is very noticeable how slow this is - trying to navigate a paginated view takes forever.

Solution - we can't do pagination using built-in Beets queries, but we can should be able to use lib.transaction to perform our own SQLite query. Instead of paginating in memory we would paginate with built-in sqlite limits and offsets.

@BinaryBrain
Copy link
Owner

Yes, I totally agree. I took some shortcut to have a working version but this is the kind of optimization I need to do next.

@gryphonmyers
Copy link
Author

If I can find some time I am also willing to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants