[Client] Inconsistent Default vs skip_serializing_none usage for status pages

[CommanderStorm]

Hi, I just tried to use the client and I came across a bit of a weird API-decision.

I wanted to ask if the partial usage of skip_serializing_none and the partial usage of Default is intentional and If you'd like a PR for this (in either direction)

here Default is not implemented

AutoKuma/kuma-client/src/models/status_page.rs

Lines 62 to 66 in 8e16d11

	#[serde_inline_default]
	#[skip_serializing_none]
	#[serde_as]
	#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
	pub struct StatusPage {

vs here Default is implemented

AutoKuma/kuma-client/src/models/monitor.rs

Lines 144 to 148 in 8e16d11

	impl Default for $struct_name {
	fn default() -> Self {
	serde_json::from_value(json!({})).unwrap()
	}
	}

The result is that the handy ..Default::default() shorthand does not work for all models.

PS:
during trying the stus page I came acros this design decision:

AutoKuma/kuma-client/src/models/status_page.rs

Line 81 in 8e16d11

pub icon: Option<String>,

=> this should be icon: String with a data:..-url. there is a patch for this in an upcoming release where we are going to accept urls there, but currently only data:

[BigBoot]

Hi

I wanted to ask if the partial usage of skip_serializing_none and the partial usage of Default is intentional and If you'd like a PR for this (in either direction)

here Default is not implemented

AutoKuma/kuma-client/src/models/status_page.rs

Lines 62 to 66 in 8e16d11

	#[serde_inline_default]
	#[skip_serializing_none]
	#[serde_as]
	#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
	pub struct StatusPage {

vs here Default is implemented

AutoKuma/kuma-client/src/models/monitor.rs

Lines 144 to 148 in 8e16d11

	impl Default for $struct_name {
	fn default() -> Self {
	serde_json::from_value(json!({})).unwrap()
	}
	}

The result is that the handy ..Default::default() shorthand does not work for all models.

I've added a Default implementation for all of the models now. Since there is no formal definition of the models in Uptime Kuma I went with Option and skip_serializing_none everywhere to directly relay missing property error message from server.

PS: during trying the stus page I came acros this design decision:

AutoKuma/kuma-client/src/models/status_page.rs

Line 81 in 8e16d11

pub icon: Option<String>,

=> this should be icon: String with a data:..-url. there is a patch for this in an upcoming release where we are going to accept urls there, but currently only data:

See my reasoning above for the decision to use Option. I've also added a small workaround for setting urls as icons, so this should work now.

[CommanderStorm]

thanks 😍 🎉