Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the verse of the day #10

Open
fpereira1 opened this issue Dec 7, 2014 · 3 comments
Open

Cache the verse of the day #10

fpereira1 opened this issue Dec 7, 2014 · 3 comments
Labels
enhancement

Comments

@fpereira1
Copy link
Contributor

Looking at caching in memory the verse of the day on the homepage as the http request to the api may cause issues when load hits.
@IonicaBizau
Copy link
Member

Probably just a variable?

@fpereira1
Copy link
Contributor Author

Yes, makes sense, was thinking about https://www.npmjs.org/package/memory-cache but probably don't need, do you see that as a change to https://github.com/BibleJS/bible-english ? Also wonder if there's a cache flag on request module

@IonicaBizau
Copy link
Member

Probably in bible.js core: BibleJS/bible.js#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fpereira1 @IonicaBizau