Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMOLib API change 1.6.2 #2801

Open
2 tasks done
Wolf2323 opened this issue May 21, 2024 · 0 comments
Open
2 tasks done

MMOLib API change 1.6.2 #2801

Wolf2323 opened this issue May 21, 2024 · 0 comments
Labels
Bug A bug in the code or in a documentation.

Comments

@Wolf2323
Copy link
Member

Wolf2323 commented May 21, 2024

Confirm the following

  • I use the latest release or dev-build. I also checked that this problem hasn't already been fixed in a newer dev-build.
  • There are no open or closed issues that are related to my problem.

BetonQuest version information

BetonQuest version: 2.1.1
Server version: git-Pufferfish-49 (MC: 1.20.4)
Hooked into: Citizens (2.0.33-SNAPSHOT (build 3399)), DecentHolograms (2.8.6), LuckPerms (5.4.117), MMOCore (1.12.1-SNAPSHOT), MMOItems (6.10-SNAPSHOT), MythicLib (1.6.2-SNAPSHOT), MythicMobs (5.5.1-9aedaa15), PlaceholderAPI (2.11.5), ProtocolLib (5.2.1-SNAPSHOT-685), Shopkeepers (2.19.0), Vault (1.7.3-b131), WorldEdit (7.2.19+6642-415ef95), WorldGuard (7.0.9+5934e49)

Expected behaviour

Hook with MMOLib is working without exceptions

Actual behaviour

There is an exception

Steps to reproduce

install the latest versions and run the server

Error, Warning, Exception or Thread Dump

[18:35:45 ERROR]: Could not pass event SkillCastEvent to BetonQuest v2.1.1
java.lang.NoSuchMethodError: 'boolean io.lumine.mythic.lib.skill.result.SkillResult.isSuccessful(io.lumine.mythic.lib.skill.SkillMetadata)'
        at org.betonquest.betonquest.compatibility.mmogroup.mmolib.MythicLibSkillObjective.onSkillCast(MythicLibSkillObjective.java:77) ~[BetonQuest (5).jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1469.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:git-Pufferfish-49]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.lumine.mythic.lib.skill.Skill.castInstantly(Skill.java:87) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at io.lumine.mythic.lib.skill.Skill.cast(Skill.java:64) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at io.lumine.mythic.lib.skill.Skill.cast(Skill.java:43) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at io.lumine.mythic.lib.api.player.MMOPlayerData.triggerSkills(MMOPlayerData.java:286) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at io.lumine.mythic.lib.api.player.MMOPlayerData.triggerSkills(MMOPlayerData.java:270) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at io.lumine.mythic.lib.listener.SkillTriggers.attack(SkillTriggers.java:50) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor410.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:git-Pufferfish-49]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.lumine.mythic.lib.listener.event.AttackEventListener.registerEvents(AttackEventListener.java:58) ~[MythicLib-dist-1.6.2-20240514.063309-42.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor398.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:git-Pufferfish-49]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617) ~[pufferfish-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.callEvent(CraftEventFactory.java:267) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:1203) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:1188) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:1120) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:1081) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:1237) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.world.entity.LivingEntity.actuallyHurt(LivingEntity.java:2269) ~[?:?]
        at net.minecraft.world.entity.LivingEntity.hurt(LivingEntity.java:1492) ~[?:?]
        at net.minecraft.world.entity.monster.Zombie.hurt(Zombie.java:319) ~[?:?]
        at net.minecraft.world.entity.player.Player.attack(Player.java:1323) ~[?:?]
        at net.minecraft.server.level.ServerPlayer.attack(ServerPlayer.java:2283) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl$3.a(ServerGamePacketListenerImpl.java:2788) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket$1.dispatch(ServerboundInteractPacket.java:24) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.dispatch(ServerboundInteractPacket.java:80) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleInteract(ServerGamePacketListenerImpl.java:2712) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:67) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:12) ~[?:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1472) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:123) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1449) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1372) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:133) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1350) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1239) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[pufferfish-1.20.4.jar:git-Pufferfish-49]
        at java.lang.Thread.run(Thread.java:1583) ~[?:?]

Additional information

I already found out that the code was changed here:

https://gitlab.com/phoenix-dvpmt/mythiclib/-/blob/master/mythiclib-plugin/src/main/java/io/lumine/mythic/lib/skill/result/SkillResult.java
https://gitlab.com/phoenix-dvpmt/mythiclib/-/commit/7a8b0706b78ea6659d0076630d4110a28d5fa94c
https://www.spigotmc.org/resources/90306/

We will update once 1.6.2 is released

@Wolf2323 Wolf2323 added the Bug A bug in the code or in a documentation. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the code or in a documentation.
Projects
Status: Blocked
Development

No branches or pull requests

1 participant