You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hiding of Players and Entities should be handled consistent and correctly. With maybe some configurable options
Actual behaviour
The current hiding has two main issues:
PlayerHider
Uses the hidePlayer method from bukkit
Also hides players from the tab list and from tab completion what is not always expected.
EntityHilder
Uses ProtocolLib package hiding
Only hides entities package based what keeps the hitboxes some particles and sounds, and also does not hide things like shot arrows
Steps to reproduce
Use the PlayerHider nad watch the Tab list or try to tab complete the player
Use the NPCHider/MythicMob(private mods) feature and shoot them with an arrow while they are hidden
Error, Warning, Exception or Thread Dump
none
Additional information
This is more like a rework then an actual bug/issue, but it could cause issues
The text was updated successfully, but these errors were encountered:
Confirm the following
BetonQuest version information
BetonQuest version: 2.0.0-DEV-702
Server version: git-Paper-111 (MC: 1.20.1)
Hooked into: Citizens (2.0.32-SNAPSHOT (build 3198)), DecentHolograms (2.8.3), ProtocolLib (5.1.0), WorldEdit (7.3.0-SNAPSHOT+6498-ff8e505)
Expected behaviour
Hiding of Players and Entities should be handled consistent and correctly. With maybe some configurable options
Actual behaviour
The current hiding has two main issues:
PlayerHider
Uses the
hidePlayer
method from bukkitAlso hides players from the tab list and from tab completion what is not always expected.
EntityHilder
Uses ProtocolLib package hiding
Only hides entities package based what keeps the hitboxes some particles and sounds, and also does not hide things like shot arrows
Steps to reproduce
Use the PlayerHider nad watch the Tab list or try to tab complete the player
Use the NPCHider/MythicMob(private mods) feature and shoot them with an arrow while they are hidden
Error, Warning, Exception or Thread Dump
Additional information
This is more like a rework then an actual bug/issue, but it could cause issues
The text was updated successfully, but these errors were encountered: