-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URL variables and small enhancements #162
Use URL variables and small enhancements #162
Conversation
Can we remove these commented lines from install-core?
|
@BenWestgate Pulled in all the changes from my 73-dont-hardcode-urls-epic fork branch. Next step is to test the changes, then I'll set the PR ready to review. |
I don't think so. Since Tails 6 there has been a problem with |
Closes #73. |
The script is stalling, possibly on the guix.sigs step. Here's the logs: pastebin.com/cETm7xuM |
It's getting stuck from thisssssss: NEW_VER is assigned in the sub-shell () so it's not available outside of that so it doesn't open up the new directory. I am going to do that thing with named pipes I told you to fix it. Unless you want to try the new skill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the merge conflict and also resolved the process communication by backgrounding setup-persistence, that way the keys import runs in the main thread.
I also got rid of the Tor fallback since its been down for a year. I also don't use recursive rsync I query for the lastest version and set it in a constant.
Should be easier to read this way.
… immediately and avoid race condition w/ `install-core`
…retry_on_fail, force README, backup bitcoin.conf before clobbering.
@epiccurious: I've cleaned up the terminal output quite a bit and it behaves how you expected now. Take a look when you get a chance. I also found and protected against a couple race conditions that were previously causing "download" failures more often than they actually happened. Learned quite a bit today. |
… selected, don't clear terminal
@epiccurious: For the -choosedatadir window from Bitcoin Core, do you want me to recreate a simplified substitute of it in zenity with the following? Like this? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Re-create the changes from this PR, including:
.onion
andbitcoincore.org
) for downloading tarball, checksum, and signatures